Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More highlighter-related test fixes #2

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

reta
Copy link

@reta reta commented Feb 18, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

More highlighter-related test fixes

Issues Resolved

Part of opensearch-project#1109

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@@ -35,7 +35,7 @@
/**
* Forked from Lucene 8.x; removed in Lucene 8.9
*
* @todo further investigate a better alternative
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc check complains:

> Task :server:javadoc server/src/main/java/org/apache/lucene/util/packed/XPackedInts.java:38: error: unknown tag: todo
 * @todo further investigate a better alternative
   ^
1 error

@nknize nknize merged this pull request into nknize:upgrade/lucene9 Feb 22, 2022
nknize pushed a commit that referenced this pull request Mar 13, 2022
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize pushed a commit that referenced this pull request Mar 15, 2022
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants