Refactor styles for AudioRecorder to prevent overflowing #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customize the AudioPlayer to only display a play button and the audio duratio n time.
ijemmao
requested changes
May 30, 2023
| @@ -1,7 +1,8 @@ | |||
| import React, { ReactElement, useEffect, useState } from 'react'; | |||
| import { has, get } from 'lodash'; | |||
| import { Record } from 'react-admin'; | |||
| import ReactAudioPlayer from 'react-audio-player'; | |||
There was a problem hiding this comment.
do you want to uninstall react-audio-player from the project?
There was a problem hiding this comment.
react-audio-player is still used as a dependency in several other components, uninstalling it will break the application. Replacing all use cases of react-audio-player with react-h5-audio-player might also break the UI.
There was a problem hiding this comment.
I was thinking the PR has been merged already
|
@Chimise are you still working on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dialectal variation options overflow parent component
Solution
Refactor the inner container styles to use flex-wrap and the children elements to use padding instead of margins. Also, update the audio player to use a new customizable React library.
Before & After Screenshots
BEFORE:
AFTER:
QA
Other changes (e.g. bug fixes, UI tweaks, small refactors)
Changes to the audio player UI, currently display only the audio duration time and the play button.
New dependencies:
react-h5-audio-player: A highly customizable audio-player for React apps.