Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fake URI path AWS #394

Open
ijemmao opened this issue Jun 28, 2023 · 2 comments · May be fixed by #406
Open

Change fake URI path AWS #394

ijemmao opened this issue Jun 28, 2023 · 2 comments · May be fixed by #406
Assignees
Labels
good first issue Good for newcomers

Comments

@ijemmao
Copy link
Collaborator

ijemmao commented Jun 28, 2023

Is your feature request related to a problem? Please describe.
We want to change the fake Uri path from https://igbo-api-test-local/${mediaPath}/ to https://igbo-api-test-local.com/${mediaPath}/

Specifically, we want to add .com to the end of the hostname so that we can better match the expected functionality of AWS.

Describe the solution you'd like
Change that fake Uri path and update all tests that will be affected by this change.

Additional context
Line in initializeAPI.ts to change

@ijemmao ijemmao added the good first issue Good for newcomers label Jun 28, 2023
@Josephchinedu
Copy link

Hi @ijemmao, I want to work on this issue.

@ijemmao
Copy link
Collaborator Author

ijemmao commented Jun 29, 2023

@Josephchinedu all yours!

kingdanie added a commit to kingdanie/igbo-api-admin that referenced this issue Jul 4, 2023
@kingdanie kingdanie linked a pull request Jul 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants