feat(attributes): use frequency alongside isCommon

[Effiti]

this can be the first step in an effort towards deprecating isCommon

[ijemmao]

really good stuff! super close

[ijemmao]

@Effiti LGTM just to confirm, did you run this migration locally to see if it works as expected?

[Effiti]

@Effiti LGTM just to confirm, did you run this migration locally to see if it works as expected?

@ijemmao having some problems with starting using docker,
the mongodb docker image doesn't work, but it is seemingly unrelated to the PR.

[ijemmao]

@Effiti you don't need to run docker! you can just follow the testing portion of the README

[Effiti]

still having some problems with connecting to the database:
running yarn migrate-up
and mongod --port 27017 --dbpath ./db simultaneously in the repo gives the following:
(somehow it works now)
after the following commit, it worked for me

[ijemmao]

@Effiti it seems like our pipeline is blocked by a weird yarn error! I've commented on the related thread to see if there's any solution to the bug: yarnpkg/yarn#8580 (comment)

If we don't hear back soon (by Wednesday at the very latest), I'll consider switching from yarn to npm so we can unblock deploys

[ijemmao]

@Effiti it looks like our README didn't walk through an extra necessary step to contribute (apologies!) here's the guide

[Effiti]

@ijemmao do I have to close and reopen the PR?

I followed the instructions but the CI is still not working. Here is a screenshot of the settings page:

[ijemmao]

@Effiti hmm yeah this is odd :/ i did find this thread that could be related:

https://github.com/orgs/community/discussions/26283

(thanks for your patience, i'm gonna fork my own repository to make a change to see if i can fix the bug locally)

[Effiti]

I set up ssh authentication for git on my machine (i think that's what the discussion was referring to), even though I already had GPG-Signing set up for git before.

I'm just gonna keep fixing minor issues in the README in order to trigger the CI until the issue is resolved 😄.