Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve code]: components/Client..その他 手動formatter・Linter対応 #99

Merged
merged 5 commits into from
Apr 14, 2024

Conversation

ZEKE320
Copy link
Collaborator

@ZEKE320 ZEKE320 commented Apr 13, 2024

Resolves #60

以下対応済みです

  • a669a5e astro/src/components/Client/{*.tsx,intents/*,pagedb/*}にPrettierを適用
  • 1a184b7 再代入されない変数をconst宣言に変更
  • a7e2fdc <a target="_blank">rel="noreferrer"を追加
  • c0d6d1f Promise<void>を返す関数にvoid演算子を追加
  • 57ef832 繰り返し表示される要素に市井のキーを割り当て

Copy link

Deploying skyshare with  Cloudflare Pages  Cloudflare Pages

Latest commit: 57ef832
Status: ✅  Deploy successful!
Preview URL: https://ac6b942e.skyshare.pages.dev
Branch Preview URL: https://feature-issue-60.skyshare.pages.dev

View logs

@ZEKE320 ZEKE320 linked an issue Apr 13, 2024 that may be closed by this pull request
11 tasks
@ZEKE320
Copy link
Collaborator Author

ZEKE320 commented Apr 13, 2024

対応完了しました
レビューをお願いします!

Copy link
Owner

@nkte8 nkte8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございました!問題ないと思います。マージします

メモ: Appform.tsxは整形済みだったためチェンジ無し

@nkte8 nkte8 merged commit 00835eb into develop Apr 14, 2024
7 checks passed
@nkte8 nkte8 deleted the feature/issue_60 branch April 14, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve code]: components/Client..その他 手動formatter・Linter対応
2 participants