generated from nl-design-system/example
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/purmerend marwa #835
Draft
Marwaxhello
wants to merge
5
commits into
main
Choose a base branch
from
feat/purmerend-marwa
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feat/purmerend marwa #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marwaxhello
force-pushed
the
feat/purmerend-marwa
branch
from
November 27, 2024 12:59
4056afb
to
40b7f83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
=======================================
Coverage 89.48% 89.48%
=======================================
Files 19 19
Lines 1332 1332
Branches 178 178
=======================================
Hits 1192 1192
+ Misses 140 139 -1
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
Marwaxhello
force-pushed
the
feat/purmerend-marwa
branch
from
November 28, 2024 12:33
0fa10b5
to
cc4728f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
In deze PR heb ik de
Drak-Mode
enLight-Mode
kleuren van de Purmerend thema aangepast.Ik heb de volgende kleuren aangepast:
button
normal en hover statealert
link
in focus hover en normal statetestarea
border en hoverempty box
borderform field description
Issues
Darkmode en Lightmode werken bijna volledig, maar er ontbreken nog een paar aanpassingen die ik niet zelf kon maken en waarvoor ik verder onderzoek moest gaan doen. De volgende issues hiervoor aangemaakt: