Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GPytorch #91

Merged
merged 25 commits into from
Jun 18, 2021
Merged

Add support for GPytorch #91

merged 25 commits into from
Jun 18, 2021

Conversation

felipeZ
Copy link
Member

@felipeZ felipeZ commented Jun 15, 2021

changes

@felipeZ felipeZ requested a review from NicoRenaud June 15, 2021 14:41
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #91 (1b760a8) into main (0888025) will increase coverage by 0.70%.
The diff coverage is 95.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   91.35%   92.06%   +0.70%     
==========================================
  Files          28       31       +3     
  Lines         810      970     +160     
  Branches       60       70      +10     
==========================================
+ Hits          740      893     +153     
- Misses         49       55       +6     
- Partials       21       22       +1     
Impacted Files Coverage Δ
swan/modeller/gp_modeller.py 91.39% <91.39%> (ø)
swan/__init__.py 100.00% <100.00%> (ø)
swan/dataset/__init__.py 100.00% <100.00%> (ø)
swan/dataset/splitter.py 100.00% <100.00%> (ø)
swan/modeller/__init__.py 100.00% <100.00%> (ø)
swan/modeller/base_modeller.py 82.14% <100.00%> (+0.66%) ⬆️
swan/modeller/models/__init__.py 100.00% <100.00%> (ø)
swan/modeller/models/gaussian_process.py 100.00% <100.00%> (ø)
swan/modeller/scikit_modeller.py 89.28% <100.00%> (+1.28%) ⬆️
swan/modeller/torch_modeller.py 93.49% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0888025...1b760a8. Read the comment docs.

Copy link
Contributor

@NicoRenaud NicoRenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but it's difficult to say more without further knowledge of gpytorch

scripts/run_torch_models.py Show resolved Hide resolved
@felipeZ felipeZ marked this pull request as ready for review June 18, 2021 09:43
@felipeZ felipeZ merged commit 98ff8b6 into main Jun 18, 2021
@felipeZ felipeZ mentioned this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants