-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RcppParallel linker flags for StanHeaders 2.26 Compatibility #5
Conversation
Thanks |
Same deal as with nlmixr2est. |
Same as |
Cran wanted cpp17 instead of cpp14. With the flags you supplied and cpp17 I have the following issue: Dear maintainer, Please see the problems shown on Please correct before 2023-03-31 to safely retain your package on CRAN. The CRAN Team Does this need cpp14? |
I can revert everything but I sm sure that doesn't help you. |
Don't revert; we'll figure it out. Does nlmixr2 compile with the C++14 standard (but continuing to link to TBB)? |
I believe you just need to replace |
Thanks @andrjohns I will try it out and resubmit to CRAN. @bgoodri it linked without linking to the tbb threads library in the past, so I'm unsure. I use the backward AD engine only if that helps answer your question. I separated out the stan pieces from |
With the current StanHeaders / rstan on CRAN, linking to TBB was somewhat optional and it would work either way if TBB was not utilized. With the next StanHeaders / rstan, linking to TBB is mandatory and there will be a linker error otherwise. So, the change to the linker flags is necessary for the next StanHeaders to have a smooth(er) path to CRAN. The stuff about the C++ standard and |
This PR updates your package to additionally link against
RcppParallel
, which will be needed for the next version ofStanHeaders