Issue #195 - update Travis to Trusty due to gcc/clang strtod() bug #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlohmann
added a commit
that referenced
this pull request
Jan 26, 2016
Issue #195 - update Travis to Trusty due to gcc/clang strtod() bug
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates Travis to use the Ubuntu Trusty distribution instead of Precise. This is required due to the bug in
strtod()that is uncorrected in Precise builds of the standard library but fixed in Trusty. This bug causes a single bit rounding error that may occur in as many as 1 in 4096 of the possible double values.Note that currently this PR still uses the
llvm-toolchain-precise*repositories because thellvm-toolchain-trusty*ones have not been added to the Travis white-list. This works because clang is not the problem, rather it is the standard library.There is an open issue on Travis APT source whitelist request for llvm-toolchain-trusty #199 to add the repositories to the white-list at which point
.travis.ymlcan be further updated. It is suggested that perhaps this pull be merged but issue #195 be left open until the trusty llvm repos can be added as well.