Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR#1006 #2158

Merged
merged 4 commits into from
Jun 5, 2020
Merged

Fix PR#1006 #2158

merged 4 commits into from
Jun 5, 2020

Conversation

dota17
Copy link
Contributor

@dota17 dota17 commented Jun 2, 2020 •
edited
Loading

PR #1006 should made some change comment in the code.
and its test case need to change a bit: remove duplicate test items list, replaced by object item, the data comes from its original old commit.

@dota17 dota17 requested a review from nlohmann as a code owner June 2, 2020 08:56
@dota17 dota17 changed the title Output adapter Fix PR#1006 Jun 2, 2020
@coveralls
Copy link

coveralls commented Jun 2, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 0f67c58 on dota17:output_adapter into 53ef076 on nlohmann:develop.

nlohmann
nlohmann approved these changes Jun 5, 2020
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jun 5, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone Jun 5, 2020
@nlohmann nlohmann merged commit 5fe6b83 into nlohmann:develop Jun 5, 2020
@nlohmann
Copy link
Owner

nlohmann commented Jun 5, 2020

Thanks!

@dota17 dota17 deleted the output_adapter branch June 5, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dota17 @coveralls @nlohmann