-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode escaping #22
Unicode escaping #22
Conversation
Thanks, I'll have a look. FYI: In the unit tests, you can access private methods - at least when the code is compiled with the Automake files, because |
Sounds good to me, updated the branch! |
Just realized I effectively reverted your commit |
- removed IDE leftovers - adjusted const’ness of some functions - style guide
Thanks a lot! This Unicode business is really a pain! |
Sync Fork from Upstream Repo
Implements the \uXXXX and \uXXXX\uXXXX unicode escape mechanisms of JSON.
This branch has a problem with code coverage as there is one method which has a untestable case (line 2215).
This code is only reachable if
So we need a way to directly access the
codePointToUTF8
method from the test header to get the line coverage back to 100%.Any recommendation how we do that in a nice way?