Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize floating-point numbers with 32 bit when possible (MessagePack) #2201

Merged
merged 3 commits into from
Jun 20, 2020
Merged

Serialize floating-point numbers with 32 bit when possible (MessagePack) #2201

merged 3 commits into from
Jun 20, 2020

Conversation

nlohmann
Copy link
Owner

This PR adds the same optimization we had in #2044 to MessagePack.

Closes #2196

@nlohmann nlohmann added this to the Release 3.8.1 milestone Jun 19, 2020
@nlohmann nlohmann self-assigned this Jun 19, 2020
@coveralls
Copy link

coveralls commented Jun 19, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling b64002b on issue2196 into e7452d8 on develop.

@nlohmann nlohmann merged commit 74c6e42 into develop Jun 20, 2020
@nlohmann nlohmann deleted the issue2196 branch June 20, 2020 07:31
@nlohmann
Copy link
Owner Author

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
aspect: binary formats BSON, CBOR, MessagePack, UBJSON release item: 🔨 further change
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

msgpack serialisation : float is treated as 64bit float, not 32bit float.
2 participants
@nlohmann @coveralls