Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion from empty json to std::optional<> #2229

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Fix conversion from empty json to std::optional<> #2229

wants to merge 11 commits into from

Commits on Jan 7, 2023

  1. 🚧 conversions for std::optional

    @nlohmann @karzhenkov
    nlohmann authored and karzhenkov committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    f6f169e View commit details
    Browse the repository at this point in the history

  2. Class template nlohmann::optional

    @karzhenkov
    karzhenkov committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    57f0f50 View commit details
    Browse the repository at this point in the history

  3. Don't derive nlohmann::optional from std::optional

    @karzhenkov
    karzhenkov committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    3854934 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2023

  1. Fix warning about constness

    @karzhenkov
    karzhenkov committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    adf7e03 View commit details
    Browse the repository at this point in the history

  2. Add noexcept

    @karzhenkov
    karzhenkov committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    24f2ce7 View commit details
    Browse the repository at this point in the history

  3. Add comment about a trick for GCC8.1

    @karzhenkov
    karzhenkov committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    7510f32 View commit details
    Browse the repository at this point in the history

  4. Add explicit member initialization to mitigate -Werror=effc++

    @karzhenkov
    karzhenkov committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    1bef046 View commit details
    Browse the repository at this point in the history

  5. Fix warning about constness

    @karzhenkov
    karzhenkov committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    9026493 View commit details
    Browse the repository at this point in the history

  6. More tests for optional comparisons

    @karzhenkov
    karzhenkov committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    7745f59 View commit details
    Browse the repository at this point in the history

  7. Use macros when comparing optional

    @karzhenkov
    karzhenkov committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    d3f72b1 View commit details
    Browse the repository at this point in the history

  8. Remove noexcept from optional comparisons

    @karzhenkov
    karzhenkov committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    14e3318 View commit details
    Browse the repository at this point in the history