Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lexer to properly cope with repeated comments #2332

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Fix lexer to properly cope with repeated comments #2332

merged 1 commit into from
Aug 1, 2020

Conversation

nlohmann
Copy link
Owner

This PR fixes a bug in the lexer that treated repeated comments as parse errors even if ignore_comment was set to true.

Closes #2330.

@nlohmann nlohmann added this to the Release 3.9.1 milestone Jul 31, 2020
@nlohmann nlohmann self-assigned this Jul 31, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3888b16 on issue2330 into 1da9317 on develop.

@nlohmann nlohmann merged commit 8a54617 into develop Aug 1, 2020
@nlohmann nlohmann deleted the issue2330 branch August 1, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.9.1
Development

Successfully merging this pull request may close these issues.

ignore_comment=true fails on multiple consecutive lines starting with comments
2 participants
@nlohmann @coveralls