Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow parsing from std::byte containers #2550

Merged
merged 12 commits into from
Dec 30, 2020
Merged

Allow parsing from std::byte containers #2550

merged 12 commits into from
Dec 30, 2020

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Dec 28, 2020 •
edited
Loading

Fixes the lexer to read from containers of std::byte.

Closes #2546.

Todo:

  • add regression test

@nlohmann nlohmann self-assigned this Dec 28, 2020
@coveralls
Copy link

coveralls commented Dec 28, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling fc7e181 on std_bytes into ff3863d on develop.

@nlohmann nlohmann added this to the Release 3.9.2 milestone Dec 29, 2020
@nlohmann nlohmann merged commit a8398a7 into develop Dec 30, 2020
@nlohmann nlohmann deleted the std_bytes branch December 30, 2020 07:33
@nlohmann nlohmann mentioned this pull request Dec 30, 2020
Closed
3 tasks
@nlohmann nlohmann linked an issue Dec 31, 2020 that may be closed by this pull request
Compilation failure of tests with C++20 standard (caused by change of u8 literals) #2413
Closed
3 tasks
@nlohmann nlohmann mentioned this pull request Jan 21, 2021
Closed
3 tasks
@nlohmann nlohmann linked an issue Jan 21, 2021 that may be closed by this pull request
Parse from byte-vector results in compile error #2602
Closed
3 tasks
@nlohmann nlohmann mentioned this pull request Jul 15, 2021
Closed
@nlohmann nlohmann linked an issue Jul 15, 2021 that may be closed by this pull request
can't parse std::vector<std::byte> #2869
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: ⚡ improvement
Projects
None yet
Milestone
Release 3.10.0
2 participants
@nlohmann @coveralls