Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if different version is also included #3418

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Apr 4, 2022

Closes #3337

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6be9c6f on issue3337_include_guard into ab5cecb on develop.

Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I hope you keep a checklist of all the places where the version number needs to be changed on release. ;-)

@nlohmann
Copy link
Owner Author

nlohmann commented Apr 5, 2022

Looks good to me. I hope you keep a checklist of all the places where the version number needs to be changed on release. ;-)

I will need to adjust https://github.com/nlohmann/json_release_scripts for this.

@falbrechtskirchinger
Copy link
Contributor

Looks good to me. I hope you keep a checklist of all the places where the version number needs to be changed on release. ;-)

I will need to adjust https://github.com/nlohmann/json_release_scripts for this.

Oh good, you have a script. Slightly off-topic: I've been using VER_TBD as a version placeholder in the documentation in one of my branches. Would you be interested in adding something more formal to your scripts? Say VER_NEXT which could be replaced in the documentation and maybe selectively in source files (e.g., JSON_HEDLEY_DEPRECATED(VER_NEXT), etc.)?

@nlohmann nlohmann self-assigned this Apr 6, 2022
@nlohmann nlohmann added this to the Release 3.10.6 milestone Apr 6, 2022
@nlohmann nlohmann merged commit 52e16a9 into develop Apr 6, 2022
@nlohmann nlohmann deleted the issue3337_include_guard branch April 6, 2022 06:29
@mortenfyhn
Copy link
Contributor

Fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants