-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ndarray dimension signedness, fix ndarray length overflow (2); add 32bit unit test #3523
Fix ndarray dimension signedness, fix ndarray length overflow (2); add 32bit unit test #3523
Conversation
@nlohmann Hm. The automatic detection part is failing spectacularly. Also, the CI image is missing some bits to make this work. |
The test can be enabled by setting JSON_32bitTest=ON.
Certain lines are unreachable in 64bit builds.
I've verified that
|
efd53c2
to
fc6ac6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! Let's see whether the fuzzer is satisfied now :) |
Replaces #3521.
Closes #3519.