Fix for printing long doubles bug in dump_float #3929
Conversation
When you use long double as a floating point type with the current version of this file and try to dump json it prints trash instead of actual number. This if-else fixes the problem. On using long double you just need to add an 'L' modifier before 'g' in format string.
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @RUSLoker Please read and follow the Contribution Guidelines. |
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @RUSLoker Please read and follow the Contribution Guidelines. |
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @RUSLoker Please read and follow the Contribution Guidelines. |
|
I think a test is missing or? |
|
Yes, a test is definitely required. There is also #3906 that I need to take care of to finally have a green CI again. I'm busy right now, so sorry for delays. |
|
Please update to recent develop version - the CI is fixed there (see #3906). |
|
@nlohmann, it asks for your approval to run CI workflows. |
|
@nlohmann, @gregmarr, what's wrong with Cirrus CI / check? |
Looks like a glitch. |
|
Any update on this? Tests are still missing. |
|
Please update to the latest develop branch and add a test. |
When you use long double as a floating point type with the current version of include/nlohmann/detail/output/serializer.hpp and try to dump json it prints trash instead of actual number. This if-else fixes the problem. On using long double you just need to add an 'L' modifier before 'g' in format string.