-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more specific error message when attempting to parse empty input #4180
Add more specific error message when attempting to parse empty input #4180
Conversation
29c0acf
to
cca9375
Compare
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @colbychaskell |
1 similar comment
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @colbychaskell |
Can you please try to amalgamate with an older version of astyle, like astyle 3.2? There was a breaking change in astyle which makes the output differ unfortunately. |
cca9375
to
750fc47
Compare
@nlohmann amalgamated with astyle 3.1 and it seems to have worked correctly now |
750fc47
to
5c22104
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thanks! |
Addresses #4037
Modifies the sax parser to create an exception with a more specific error message when attempting to parse an empty input string or stream.
Modifies corresponding tests to expect the new error message.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filessingle_include/nlohmann/json.hpp
andsingle_include/nlohmann/json_fwd.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.