Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Allow computing fine-grained/weighted-based scores #11

Closed
Tracked by #35
neoncitylights opened this issue Dec 29, 2022 · 0 comments · Fixed by #40
Closed
Tracked by #35

feature: Allow computing fine-grained/weighted-based scores #11

neoncitylights opened this issue Dec 29, 2022 · 0 comments · Fixed by #40
Assignees
@notalfredo
Labels
lvl-2-medium Medium-ranking issue p1-low Priority 1: Generally no one plans to work on the task, but it would be nice if someone decides to. t-feature-request Type: Idea/request of an enhancement towards a library/framework

Comments

@neoncitylights
Copy link
Contributor

neoncitylights commented Dec 29, 2022 •
edited
Loading

Note: This task is blocked by task #10.

If you were to compare battle and cattle, they would be 83.33...% similar (5/6). However, if you were to compare Battle and battle, they would still technically be 83.33...% similar as well. Of course though, this type of substitution isn't a change of letters, it's a change of letter case (upper-to-lower & vice versa).

What if instead, it'd be possible to have a weighted score? Full letter substitutions have a 1.0 penalty, and letter-case substitutions would have a 0.5 penalty.

This would give a relatively more accurate similarity than before, which would be a 5.5/6 instead, or 91.66...%.
@neoncitylights neoncitylights changed the title feature: Allow computing weighted-based scores feature: Allow computing fine-grained/weighted-based scores Dec 29, 2022
@neoncitylights neoncitylights added lvl-2-medium Medium-ranking issue p1-low Priority 1: Generally no one plans to work on the task, but it would be nice if someone decides to. t-feature-request Type: Idea/request of an enhancement towards a library/framework labels Dec 29, 2022
This was referenced Jan 5, 2023
Open
Closed
Closed
@notalfredo notalfredo self-assigned this Jan 13, 2023
notalfredo added a commit that referenced this issue Jan 14, 2023
@notalfredo
feat: similarity and difference score
54b7ac3 
fixes #10 and fixes #11
@notalfredo notalfredo mentioned this issue Jan 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notalfredo notalfredo

Labels
lvl-2-medium Medium-ranking issue p1-low Priority 1: Generally no one plans to work on the task, but it would be nice if someone decides to. t-feature-request Type: Idea/request of an enhancement towards a library/framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: similarity and difference score nlp-rs/typediff
2 participants
@neoncitylights @notalfredo