In comments, fix typos. #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR! LGTM except one nit about "eightbytes". I also flagged a couple pre-existing typos that it makes sense to fix in this PR. I'll run the workflows once you've made those changes (or let me know if you'd prefer I make them myself). Thanks for the catch about the comment in |
nlsandler
requested changes
Oct 28, 2024
| @@ -11,7 +11,7 @@ int main(void) { | |||
| } | |||
| int i = -50; | |||
| int *i_ptr = &i; | |||
| // convert i_ptr to unsigned, perform conversion, then convert back | |||
| // convert *i_ptr to unsigned, perform conversion, then convert back | |||
There was a problem hiding this comment.
Since you're updating this line anyway, could you change "perform conversion" to "perform operation"?
| @@ -1,4 +1,4 @@ | |||
| // Test comound assignment through pointers that requires type conversions | |||
| // Test comound assignment through pointers that require type conversions | |||
There was a problem hiding this comment.
Since you're fixing this line anyway, could you change "comound" to "compound"?
|
Thanks for your corrections. Please go ahead and make the adjustments. |
nlsandler
force-pushed
the
ysono/typo-generic
branch
from
cc84f99 to
2e83cb9
Compare
nlsandler
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies intra-sample comments only.
One thing I left untouched: in
tests/chapter_10/valid/libraries/external_linkage_function_client.c,add_three_and_four(), comment says thesum()function is shadowed, but it's not.