Band-aid for MySQL (Probably a part of #9) #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The printf returns "mysql_native_password" with three 0xff-bytes at the end. You might want to put that band-aid at the "packet_number == 2"-condition too, but having it at the "packet_number == 0"-condition seems to be enough to avoid a crash. Tested on Ubuntu 19.04 with a local MySQL server: ncrack --user root --pass root mysql://127.0.0.0/31 Signed-off-by: Christian Inci <chris.gh@broke-the-inter.net>
|
It seems to crash somewhere else too (with some servers), I'll look into it. |
The "packet_number == 2"-condition is also affected. The (added) printf returns "caching_sha2_password" with three 0xff-bytes at the end. Tested with MySQL 8. It crashed while having a single target selected too. (mysql://x.x.x.x/32 or just mysql://x.x.x.x/) Signed-off-by: Christian Inci <chris.gh@broke-the-inter.net>
|
It were actually needed at the "packet_number == 2"-condition too. (MySQL 8, caching_sha2_password) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The printf returns "mysql_native_password" with three 0xff-bytes at the end.
You might want to put that band-aid at the "packet_number == 2"-condition too, but having it at the "packet_number == 0"-condition seems to be enough to avoid a crash.
Tested on Ubuntu 19.04 with a local MySQL server:
ncrack --user root --pass root mysql://127.0.0.0/31
Signed-off-by: Christian Inci chris.gh@broke-the-inter.net