Allow adding test application even when smoke tests are disabled #50
Conversation
|
Thanks a lot for your contribution @mayorova. 😊I have just a small change to suggest. Aside this, could you also add the corresponding doc in the README.md ?
@lbroudoux also asked for it, so your contribution will be appreciated ! 👍 |
tasks/main.yml
Outdated
| @@ -43,7 +43,8 @@ | |||
|
|
|||
| # Create or update the default application if smoke tests are needed | |||
| - include_tasks: steps/default_application.yml | |||
| when: 'threescale_cicd_openapi_smoketest_operation|length > 0 and threescale_cicd_application_plans is defined' | |||
| when: ('threescale_cicd_openapi_smoketest_operation|length > 0 and threescale_cicd_application_plans is defined') | |||
| or 'threescale_cicd_create_test_application|bool' | |||
There was a problem hiding this comment.
Hi Daria,
Can we rewrite the test as:
(threescale_cicd_openapi_smoketest_operation|length > 0 or threescale_cicd_create_test_application|bool) and threescale_cicd_application_plans is defined
The reason is we don't want to create an application if there is no application plan defined.
Also, if you need quotes around the when condition, make sure it catches the whole string:
when: '(a and b) or c'
instead of:
when: ('a and b') or 'c'
Otherwise, your when condition is always true.
You can try it by yourself with this little playground:
https://github.com/nmasse-itix/Ansible-Examples/blob/master/when-quotes.yaml
mayorova
force-pushed
the
allow-creating-app-without-smoketest
branch
from
723a2b9 to
51873d1
Compare
mayorova
force-pushed
the
allow-creating-app-without-smoketest
branch
from
51873d1 to
e0dd643
Compare
|
Thanks a lot for the comments @nmasse-itix ! I've applied the changes. |
|
Approved. Thanks a lot @mayorova for this contribution. 👍 |
Currently the test application with the default plan is only created when the smoke tests are enabled.
However, I need to be able to create an application with smoke tests disabled.
This is because I need to redeploy the APIcast gateway first, and run the tests after that.
In this PR this can be enabled by passing
threescale_cicd_create_test_application: truevar to the playbook.Does it make sense @nmasse-itix ? Any feedback?