WIP: Add docker fetcher based on Skopeo #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fetcher relies on Skopeo to fetch metadata and download the image in order to get its sha256 and to prefetch it.
This was referenced Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fetcher relies on Skopeo to fetch image metadatas, download the image
in order to get its sha256 and to prefetch it.
To use it:
Important note: this is WIP and not really tested yet:/
The main objective of this PR is to discuss the implementation: should we create
PackageSpecsubtypes (one per fetcher for instance) in order to be able to specializePackageSpecfunctions to make them more understandable.Also, I think it would be better to first introduce the
niv addsubcommands (ie.niv add <github|docker|...>). This is coming soon.