Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation of allele specific MAC codes #276

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Validation of allele specific MAC codes #276

merged 3 commits into from
Oct 30, 2023

Conversation

pbashyal-nmdp
Copy link
Contributor

Validation of allele specific MAC codes

  • Use allele specific antigen code rules when validating MACs that cross antigen group
  • Add tests to validate allele specific antigen codes

Fixes #274

@pbashyal-nmdp pbashyal-nmdp added the bug Something isn't working label Oct 26, 2023
@pbashyal-nmdp pbashyal-nmdp self-assigned this Oct 26, 2023
mmaiers-nmdp
mmaiers-nmdp approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@mmaiers-nmdp mmaiers-nmdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If someone wants the old behavior we can make an option for it at that time.

@mmaiers-nmdp mmaiers-nmdp merged commit 84f0971 into nmdp-bioinformatics:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaiers-nmdp mmaiers-nmdp mmaiers-nmdp approved these changes

Assignees

@pbashyal-nmdp pbashyal-nmdp

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.x - Bug fixes + Enhancements
Development

Successfully merging this pull request may close these issues.

MACs with "allele specific" codes expansion
2 participants
@pbashyal-nmdp @mmaiers-nmdp