Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All recognized serology are valid. #306

Merged
merged 1 commit into from
Feb 23, 2024
Merged

All recognized serology are valid. #306

merged 1 commit into from
Feb 23, 2024

Conversation

pbashyal-nmdp
Copy link
Contributor

Consider all recognized serology to be valid, not only the ones that have corresponding DNA Alleles. e.g. DPw6

Examples:
  | Allele | Validity |
  | DR7    | Valid    |
  | DR99   | Invalid  |
  | A10    | Valid    |
  | A101   | Invalid  |
  | DQ8    | Valid    |
  | DQ20   | InValid  |
  | DPw6   | Valid    |
  | DPw7   | InValid  |
  • move all serology related functions/classes to serology.py

@pbashyal-nmdp pbashyal-nmdp added the bug Something isn't working label Feb 21, 2024
@pbashyal-nmdp pbashyal-nmdp self-assigned this Feb 21, 2024
@mmaiers-nmdp mmaiers-nmdp merged commit f577bd9 into nmdp-bioinformatics:master Feb 23, 2024
2 checks passed
@pbashyal-nmdp pbashyal-nmdp mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaiers-nmdp mmaiers-nmdp mmaiers-nmdp approved these changes

Assignees

@pbashyal-nmdp pbashyal-nmdp

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.x - Bug fixes + Enhancements
Development

Successfully merging this pull request may close these issues.
2 participants
@pbashyal-nmdp @mmaiers-nmdp