Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to codecov action #124

Merged
merged 1 commit into from
May 30, 2024
Merged

updates to codecov action #124

merged 1 commit into from
May 30, 2024

Conversation

k-doering-NOAA
Copy link
Collaborator

@k-doering-NOAA k-doering-NOAA commented May 29, 2024

addresses #122. More context in NOAA-FIMS/FIMS#605.

I tested these changes on a branch in FIMS. I made sure:

I'm wondering if I should check that the workflow fails if the upload is unsuccessful? Unfortunately, it did not, which lead to this issue not being caught quickly.

I should also note that once this change is pushed to main, I think all workflows that depend on it will fail due to the lack of a token, so this may need more documentation to help users make the changes required.

In particular, all user will need to add the upload token from codecov.io to a GitHub secret, then add the secret to the workflow yaml (or more simply, delete their caller workflow and run use_calc_coverage() again). Below is a snippet of the jobs section of the caller workflow:

jobs:
  call-workflow:
    uses: nmfs-fish-tools/ghactions4r/.github/workflows/calc-coverage.yml@main
    secrets:
      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

I also made edits to the vignette, as I don't think this workflow is general to use for codecov and coveralls anymore, unfortunately.

Copy link
Collaborator

@Bai-Li-NOAA Bai-Li-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@k-doering-NOAA k-doering-NOAA merged commit e9ad1ba into main May 30, 2024
9 checks passed
@k-doering-NOAA k-doering-NOAA deleted the fix-codecov-upload branch May 30, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants