Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #122. More context in NOAA-FIMS/FIMS#605.
I tested these changes on a branch in FIMS. I made sure:
![screenshot showing the error message](https://github.com/nmfs-fish-tools/ghactions4r/assets/48930335/adfff28e-d1d0-460a-82d8-a93d7ddf56dd
I'm wondering if I should check that the workflow fails if the upload is unsuccessful? Unfortunately, it did not, which lead to this issue not being caught quickly.
I should also note that once this change is pushed to main, I think all workflows that depend on it will fail due to the lack of a token, so this may need more documentation to help users make the changes required.
In particular, all user will need to add the upload token from codecov.io to a GitHub secret, then add the secret to the workflow yaml (or more simply, delete their caller workflow and run use_calc_coverage() again). Below is a snippet of the jobs section of the caller workflow:
I also made edits to the vignette, as I don't think this workflow is general to use for codecov and coveralls anymore, unfortunately.