-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: added alt text to cover page's US Dept of Commerce seal #68
Conversation
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
@@ -107,7 +107,7 @@ | |||
\vspace{1\baselineskip} | |||
|
|||
%%%%%% Tagline at bottom | |||
\includegraphics[width=2cm]{support_files/us_doc_logo.png}\newline | |||
\pdftooltip{\includegraphics[width=2cm]{support_files/us_doc_logo.png}}{Seal of the United States Department of Commerce}\newline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why you are using pdftooltip here when you can just add the alternative text to the call to includegraphics. Also, the seal is an artifact rather than an actual figure in my opinion and you can tag it as such so that no alternative text is needed. From W3 artifacts are "generally graphics objects or other markings that are not part of the authored content. Examples of artifacts include page header or footer information, lines or other graphics separating sections of the page, or decorative images."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kelli- thanks for your review. My responses:
I am not sure why you are using pdftooltip here when you can just add the alternative text to the call to includegraphics.
- This mistake was because I'm so new to LaTeX and was trying to implement a solution I saw on StackOverflow. Thanks for sharing the better way to do that.
Also, the seal is an artifact rather than an actual figure in my opinion and you can tag it as such so that no alternative text is needed. From W3 artifacts are "generally graphics objects or other markings that are not part of the authored content. Examples of artifacts include page header or footer information, lines or other graphics separating sections of the page, or decorative images."
- Thanks for letting me know. I agree that the seal is, in fact, in artifact. My next commit will include the .tex file with the alt text removed and the artifact tag added.
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?