Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Linf equation #186

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix typo in Linf equation #186

merged 1 commit into from
Sep 18, 2023

Conversation

arni-magnusson
Copy link
Contributor

Hi! This commit fixes a small typo in the Linf equation (Eq. 5).

@iantaylor-NOAA
Copy link
Contributor

@arni-magnusson,
Thanks for the correction.
From the GitHub Actions artifact, it looks like the resulting equation
image
matches A.1.5 in the Methot & Wetzel (2013) supplemental material
image

Copy link
Collaborator

@e-perl-NOAA e-perl-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@e-perl-NOAA e-perl-NOAA merged commit 70751ee into nmfs-ost:main Sep 18, 2023
2 checks passed
@arni-magnusson
Copy link
Contributor Author

arni-magnusson commented Sep 18, 2023

Great work, @iantaylor-NOAA, deriving the equation in the first place!

@iantaylor-NOAA
Copy link
Contributor

Wasn't me doing the deriving and credit goes to @chantelwetzel-noaa for adding the additional detail from the 2013 paper into the User Manual.

@arni-magnusson
Copy link
Contributor Author

Ha, that's interesting. In 982e553, Rick added a comment
//Ian Taylor derived the formula for Linf
so I took that at face value :)

I find it appropriate that just as L1, L2, and Linf are all pointing at each other, @chantelwetzel-noaa, @iantaylor-NOAA, and @Rick-Methot-NOAA are doing the same...

In the current draft of our tuna assessment reference handbook, the section heading now reads "Wetzel-Taylor Theorem of Growth Transformation".

@iantaylor-NOAA
Copy link
Contributor

Maybe I just have very bad memory.
@arni-magnusson is your tuna assessment reference handbook just an internal SPC document, or publicly accessible.

In reciprocity I offer this link to the Unofficial NWFSC and SWFSC Groundfish Stock Assessment Handbook https://pfmc-assessments.github.io/pfmc_assessment_handbook/ which is intended for internal use but is publicly accessible.

@arni-magnusson
Copy link
Contributor Author

arni-magnusson commented Sep 19, 2023

Thanks for sharing the NWFSC and SWFSC Groundfish Stock Assessment Handbook. It's well organized and super informative.

Sorry to disappoint, but the tuna assessment reference handbook I was referring to only contains one section, the
Wetzel-Taylor Theorem of Growth Transformation :)

Nonetheless, we have:

  1. CAPAM Tuna Stock Assessment Good Practices from March this year.

  2. SPC Proper - Quality Assurance and Quality Control for SPC Assessments, which is taking shape. It consists mainly of:

  • A standard directory tree.
  • General guidelines on how to write reproducible R scripts and organize selected parts of the assessment work on GitHub.
  • An R package that checks how well a given assessment conforms to the agreed way to work, measuring how well an assessment has been parked. (Currently a single-function package skeleton, created last week.)

SPC Proper is partly inspired by ICES TAF and GFCM STAR, which have somewhat comparable aims. The latter includes an R package that runs a suite of QC functions to check which quality criteria are fulfilled, before database import of GFCM stock assessment results. Above all, though, Proper is tailored to address the top priority need at SPC to ensure that all the elements of a stock assessment can be picked up 3 years later by a new stock assessor, as efficiently as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants