Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add 2-parm catchability (Q) option with offset and slope #595

Closed
Rick-Methot-NOAA opened this issue Apr 30, 2024 · 2 comments · Fixed by #596
Closed

[Feature]: Add 2-parm catchability (Q) option with offset and slope #595

Rick-Methot-NOAA opened this issue Apr 30, 2024 · 2 comments · Fixed by #596
Assignees
Labels
change log use for issues that should appear in change log survey_&_Q for survey, CPUE, catchability, Q
Milestone

Comments

@Rick-Methot-NOAA
Copy link
Collaborator

Rick-Methot-NOAA commented Apr 30, 2024

Describe the solution you would like.

When an environmental index is used to compare to a dev vector, including recruitment devs, there is a need for an offset parameter as well as the existing slope parameter.
This will be a step in implementation of #5

Input looks like:

#_Q_setup for fleets with cpue or survey data
#_1:  fleet number
#_2:  link type: 1=simple q; 2=mirror; 3=power (+1 parm); 4=mirror with rescale (+1p); 5=offset (+1p); 6=offset & power (+2p)
#_3:  extra input for link, i.e. mirror fleet# or dev index number
#_4:  0/1 to select extra sd parameter
#_5:  0/1 for biasadj or not
#_6:  0/1 to float
#_   fleet      link link_info  extra_se   biasadj     float  #  fleetname
         2         1         0         0         0         0  #  Survey
         3         5         0         0         0         0  #  env
-9999 0 0 0 0 0
#
#_Q_parameters
#_          LO            HI          INIT         PRIOR         PR_SD       PR_type      PHASE    env-var    use_dev   dev_mnyr   dev_mxyr     dev_PH      Block    Blk_Fxn  #  parm_name
           -20            20             0             0            99             0          3          0          0          0          0          0          0          0  #  LnQ_base_Survey(2)
         0.001            20             1             0            99             0          2          0          0          0          0          0          0          0  #  Q_base_env(3)
            -1             1             0             0            99             0          2          0          0          0          0          0          0          0  #  Q_offset_env(3)

Note that this new parameter is now labelled Q_offset. Previously the Q parameter associated with option 3 (mirror +) was called Q_offset. That is renamed to Q_scale because it is principally used to scale a CPUE to the relative area it represents.

Describe alternatives you have considered

force users to remember to zero-center their env data, but even zero-centering is an incomplete alternative to allowing for an offset parameter.

Statistical validity, if applicable

bias will be created if a non-zero centered env index is used

Describe if this is needed for a management application

bias will be created if a non-zero centered env index is used

Additional context

No response

@Rick-Methot-NOAA Rick-Methot-NOAA added the survey_&_Q for survey, CPUE, catchability, Q label Apr 30, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA added this to the 3.30.23 milestone Apr 30, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA self-assigned this Apr 30, 2024
@iantaylor-NOAA
Copy link
Contributor

Good to see this moving forward.

I wanted to note that I think the alternative of zero-centering the env data isn't necessarily a comparable solution anyway because the period of devs that are being informed by the index might not be zero-centered themselves. That is, you might have an index of recruitment deviations which you believe provides information on the relative strength of individual cohorts. If it's applied to a recent period where the other data sources suggest that recruitment was below average, a zero-centered index will pull them up if there's not an offset parameter available to make the scale of observed and expected line up. In some cases, we may want that pulling effect, in which case the offset could be fixed at 0.

@Rick-Methot-NOAA
Copy link
Collaborator Author

test case here
test_env_offset.zip

@Rick-Methot-NOAA Rick-Methot-NOAA moved this to In Progress in ss3-issue-tracker May 14, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA changed the title [Feature]: Add 2-parm catchability option with offset and slope [Feature]: Add 2-parm catchability (Q) option with offset and slope May 17, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA linked a pull request May 20, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in ss3-issue-tracker May 20, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA added change log use for issues that should appear in change log resolved issue resolved, look for "needs test" label labels Sep 19, 2024
@Rick-Methot-NOAA Rick-Methot-NOAA removed the resolved issue resolved, look for "needs test" label label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change log use for issues that should appear in change log survey_&_Q for survey, CPUE, catchability, Q
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants