-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update catchability section with env Q #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good news. I found the artifact all by myself.
One small change:
8.8.1 Mirrored Q with scale
better as:
8.8.1 Example parameter lines
@iantaylor-NOAA could you take a quick look at this just to make sure everything makes sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you @e-perl-NOAA and @Rick-Methot-NOAA for cleaning up this section and documenting the new options. Sorry I was out sick so this response is slow.
I'm not sure why the github action to link the artifacts is being skipped, but tracking them down the old way shows me that there's a quirk in how the numbered lists work in HTML vs PDF. In the HTML case, it's a little strange to have the repeated numbers (as opposed to letters preceding the numbers in PDF). See screenshot below.
I also see a misspelled "requrired".
Looks good regarding my requested change. |
@iantaylor-NOAA they should be lettered now. I added another condition to the github action that adds the artifacts because I think it was only adding them on the initial PR, not on subsequent pushes but hopefully what I added will get it adding the artifacts on pushes. |
* update catchability section about Q base, offset, and power * update github action to add artifacts to PR to also add on push
See ss3-source-code PR #596 and issue #595.
@Rick-Methot-NOAA Can you make sure the extra parameters table example looks okay?
@iantaylor-NOAA Could you take a look just to make sure it all makes sense?