Fix: increment warning where forgotten #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good idea to sleuth these out. |
|
Thanks! I now removed the commented out warning statements and pushed a fix to correct the build-warning gh action (it flagged missing parentheses, which was helpful!) @Rick-Methot-NOAA feel free to merge this in once all gh actions pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some warnings weren't getting incremented, so edited the source code to fix. Note I saw some lines were commented out with no incrementation, but I added it anyway just in case we wanted to uncomment the lines in the future.
@Rick-Methot-NOAA , please take a look. Feel free to push to the branch changes if I made any mistakes, or let me know what changes to make.