Another pull request from johnoel/stock-synthesis

[johnoel]

Concisely describe what has been changed/addressed in the pull request.

• Resolves issue #

What tests have been done?

Where are the relevant files?

What tests/review still need to be done?

Is there an input change for users to Stock Synthesis?

Additional information (optional).

[Rick-Methot-NOAA]

Hi Jon,
Elizabeth has been the team member most involved with the docker project and she will be out for a couple of weeks. Please ping me if you must have this PR reviewed sooner.
Rick

[johnoel]

Thanks Rick for letting me know. I will just wait for Elizabeth and work on other Docker improvements.

[e-perl-NOAA]

@johnoel Thank you for working on this! I'm finally back after being in and out for the past 2 weeks. I'll try this out this week and get back to you with any problems I have (hopefully I won't have any).

[e-perl-NOAA]

@johnoel, I added a comment to the code, but the reason that the actions are passing is because build-ss3.yml still contains the original code to get the admb release from GitHub. If you take those lines out, build.ss3 will not pass with the changes that you have made.

[e-perl-NOAA]

@johnoel, have you been able to dive into this more recently to see what the issue is? I would like to get this mostly solved this month so we are sure to have it wrapped up before March. Thank you!

[johnoel]

Back from vacation, I will look at this today.

[johnoel]

Hi Elizabeth (@e-perl-NOAA), can you review changes?

[e-perl-NOAA]

@johnoel please see my draft PR #550, there are some weird c++ errors now and the windows docker image still isn't working.

[johnoel]

See Pull Request #552