Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-ss3.yml with admb build from source for macos-13 #621

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

e-perl-NOAA
Copy link
Collaborator

@e-perl-NOAA e-perl-NOAA commented Sep 19, 2024

Concisely describe what has been changed/addressed in the pull request.

The macos-12 build using the admb docker image started failing after an update to the macos-12 github action runner. The macos-13 runner was also failing to build ss3 with the admb docker image. The workflow has been updated to use the macos-13 runner and build admb from source for that runner and then build ss3 rather than using the admb docker image.

See the successful build in my repo with the workflow.

What tests have been done?

Where are the relevant files?

  • No test files are required for this pull request.

What tests/review still need to be done?

None.

Is there an input change for users to Stock Synthesis?

  • No, there was no input change.

Additional information (optional).

@e-perl-NOAA e-perl-NOAA added workflows related to workflows/gh-actions build related to workflow labels Sep 19, 2024
Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can update the Docker later?

@e-perl-NOAA
Copy link
Collaborator Author

Possibly but the problem is that I'm not getting any (or any useful) error messages from the GitHub action, it just gets canceled and doesn't finish running so I'm not sure what the problem is or how to fix it. I'm hoping that maybe it's a bug with the runner that will get worked out in time but I'm really not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build related to workflow workflows related to workflows/gh-actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants