Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add the ability to configure empty bypass list for avoiding proxy bypass" #20

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

nmoinvaz
Copy link
Owner

@nmoinvaz nmoinvaz commented Feb 3, 2023

Reverts #13

@nmoinvaz nmoinvaz requested a review from sergio-nsk February 3, 2023 23:24
@nmoinvaz nmoinvaz enabled auto-merge (rebase) February 3, 2023 23:24
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #20 (ae7a46b) into master (17b1b73) will decrease coverage by 3.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   52.41%   49.06%   -3.36%     
==========================================
  Files          53       53              
  Lines        4373     4362      -11     
  Branches     1018     1017       -1     
==========================================
- Hits         2292     2140     -152     
- Misses       1449     1591     +142     
+ Partials      632      631       -1     
Flag Coverage Δ
macos 46.72% <100.00%> (-4.04%) ⬇️
ubuntu 43.29% <100.00%> (ø)
ubuntu_curl 43.48% <100.00%> (ø)
windows 51.68% <100.00%> (-3.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config.c 57.31% <100.00%> (ø)
resolver_mac.c 31.46% <0.00%> (-32.97%) ⬇️
config_win.c 59.25% <0.00%> (-24.08%) ⬇️
config_mac.c 48.69% <0.00%> (-18.81%) ⬇️
resolver_win8.c 38.70% <0.00%> (-16.13%) ⬇️
test/proxycli.c 59.33% <0.00%> (-13.34%) ⬇️
util.c 74.68% <0.00%> (-2.54%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nmoinvaz nmoinvaz added the bug Something isn't working label Feb 3, 2023
@nmoinvaz nmoinvaz merged commit 5b85f9e into master Feb 3, 2023
@nmoinvaz nmoinvaz deleted the revert-13-sergio-nsk/override-bypass-proxy/1 branch February 3, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants