Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check gnome2/3 proxy mode before returning config values. #33

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

nmoinvaz
Copy link
Owner

No description provided.

@nmoinvaz nmoinvaz added the bug Something isn't working label Feb 15, 2023
@nmoinvaz nmoinvaz requested a review from sergio-nsk February 15, 2023 23:12
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #33 (dfe63aa) into master (436d951) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   52.97%   53.01%   +0.04%     
==========================================
  Files          53       49       -4     
  Lines        4493     4227     -266     
  Branches     1050     1045       -5     
==========================================
- Hits         2380     2241     -139     
+ Misses       1466     1384      -82     
+ Partials      647      602      -45     
Flag Coverage Δ
macos ∅ <ø> (∅)
ubuntu 46.01% <0.00%> (+1.36%) ⬆️
ubuntu_curl 46.41% <0.00%> (+1.35%) ⬆️
windows 56.19% <ø> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config_gnome2.c 0.00% <0.00%> (ø)
config_gnome3.c 0.00% <0.00%> (ø)
threadpool_winxp.c 76.87% <0.00%> (-3.41%) ⬇️
test/proxycli.c 70.00% <0.00%> (-2.67%) ⬇️
util.c 79.29% <0.00%> (-1.09%) ⬇️
fetch_posix.c 42.34% <0.00%> (-0.91%) ⬇️
threadpool_pthread.c 81.25% <0.00%> (-0.63%) ⬇️
wpad_dns.c 32.35% <0.00%> (ø)
wpad_dhcp.c 0.00% <0.00%> (ø)
resolver_mac.c
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

config_gnome2.c Outdated Show resolved Hide resolved
config_gnome2.c Outdated Show resolved Hide resolved
@nmoinvaz nmoinvaz force-pushed the nathan/dev/check-mode-gnome branch 2 times, most recently from 1c4e104 to c819837 Compare February 16, 2023 19:16
@nmoinvaz nmoinvaz force-pushed the nathan/dev/check-mode-gnome branch from c819837 to dfe63aa Compare February 16, 2023 19:23
@nmoinvaz
Copy link
Owner Author

CI tests fixed.

@nmoinvaz nmoinvaz merged commit ac793eb into master Feb 16, 2023
@nmoinvaz nmoinvaz deleted the nathan/dev/check-mode-gnome branch February 16, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants