Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed various warnings when compiling on macOS #47

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Fixed various warnings when compiling on macOS #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a8b3a4
Fixed unused variables in proxy_resolver_mac_get_proxies_for_url
nmoinvaz Aug 4, 2023
223c495
Fixed error not used in print statement.
nmoinvaz Aug 4, 2023
cf5d6db
Fixed printf type warning on macOS.
nmoinvaz Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions resolver_mac.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@
CFURLRef target_url_ref = NULL;
CFURLRef url_ref = NULL;
char *auto_config_url = NULL;
char *proxy = NULL;
char *bypass_list = NULL;
bool is_ok = false;

if (!proxy_resolver || !url)
Expand All @@ -126,7 +124,7 @@
auto_config_url = proxy_config_get_auto_config_url();
if (!auto_config_url) {
proxy_resolver->error = EINVAL;
LOG_ERROR("Auto configuration url not specified", proxy_resolver->error);
LOG_ERROR("Auto configuration url not specified");

Check warning on line 127 in resolver_mac.c

View check run for this annotation

Codecov / codecov/patch

resolver_mac.c#L127 

Added line #L127 was not covered by tests
goto mac_done;
}

Expand Down
2 changes: 1 addition & 1 deletion wpad_dhcp_posix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ static bool dhcp_read_reply(SOCKET sfd, uint32_t request_xid, dhcp_msg *reply) {
const ssize_t response_len = recvfrom(sfd, (char *)reply, sizeof(dhcp_msg), 0, NULL, NULL);

if (response_len <= (ssize_t)(sizeof(dhcp_msg) - DHCP_OPT_MIN_LENGTH)) {
LOG_DEBUG("Unable to read DHCP reply (%d:%d)\n", response_len, socketerr);
LOG_DEBUG("Unable to read DHCP reply (%d:%d)\n", (int32_t)response_len, socketerr);
return false;
}

Expand Down
Loading