Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash bug when releasing IAsyncOperation_ProxyConfiguration on WinRT #51

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

nmoinvaz
Copy link
Owner

No description provided.

@nmoinvaz nmoinvaz added the bug Something isn't working label Oct 26, 2023
@nmoinvaz nmoinvaz requested a review from sergio-nsk October 26, 2023 00:44
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #51 (0e0b059) into master (bc297d2) will decrease coverage by 1.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   56.61%   55.51%   -1.11%     
==========================================
  Files          53       53              
  Lines        4608     4606       -2     
  Branches     1063     1062       -1     
==========================================
- Hits         2609     2557      -52     
- Misses       1310     1377      +67     
+ Partials      689      672      -17     
Flag Coverage Δ
macos 44.33% <ø> (-6.02%) ⬇️
ubuntu 53.30% <ø> (-0.04%) ⬇️
ubuntu_curl 53.02% <ø> (ø)
windows 56.57% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nmoinvaz
Copy link
Owner Author

nmoinvaz commented Oct 26, 2023

Seems like something unrelated is broken on macOS. I will take a look at that later.

@nmoinvaz nmoinvaz merged commit 70e3697 into master Oct 26, 2023
14 of 17 checks passed
@nmoinvaz nmoinvaz deleted the nathan/dev/winrt-crash branch October 26, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants