Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winrt: proxy_resolver should not take into account system config #55

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

sergio-nsk
Copy link
Collaborator

If the app sets user proxy.

@sergio-nsk sergio-nsk added enhancement New feature or request cleanup Housekeeping tasks labels Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (863f4af) 55.57% compared to head (69b67ff) 57.24%.

Files Patch % Lines
resolver_winxp.c 0.00% 2 Missing ⚠️
resolver_gnome3.c 0.00% 1 Missing ⚠️
resolver_posix.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   55.57%   57.24%   +1.67%     
==========================================
  Files          53       53              
  Lines        4605     4605              
  Branches     1062     1062              
==========================================
+ Hits         2559     2636      +77     
+ Misses       1375     1271     -104     
- Partials      671      698      +27     
Flag Coverage Δ
macos 51.94% <50.00%> (+7.46%) ⬆️
ubuntu 52.81% <50.00%> (-0.61%) ⬇️
ubuntu_curl 53.10% <50.00%> (ø)
windows 56.65% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergio-nsk sergio-nsk enabled auto-merge (rebase) December 7, 2023 01:16
@nmoinvaz
Copy link
Owner

nmoinvaz commented Dec 7, 2023

It seems just like const change. What am I missing here?

@sergio-nsk sergio-nsk merged commit 09e2409 into master Dec 8, 2023
16 of 18 checks passed
@sergio-nsk sergio-nsk deleted the sergey/winrt/3 branch December 8, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Housekeeping tasks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants