Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ipv6 addresses to net_adapter. #58

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

nmoinvaz
Copy link
Owner

@nmoinvaz nmoinvaz commented Dec 12, 2023

This is first part in fixing macOS local IP address issues/unit tests.

@nmoinvaz nmoinvaz added the enhancement New feature or request label Dec 12, 2023
@nmoinvaz nmoinvaz requested a review from sergio-nsk December 12, 2023 17:01
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8d75d9c) 55.68% compared to head (59a6e7b) 56.04%.

Files Patch % Lines
net_adapter_win.c 86.66% 0 Missing and 2 partials ⚠️
net_adapter_linux.c 90.00% 0 Missing and 1 partial ⚠️
net_adapter_mac.c 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   55.68%   56.04%   +0.35%     
==========================================
  Files          53       53              
  Lines        4606     4639      +33     
  Branches     1062     1071       +9     
==========================================
+ Hits         2565     2600      +35     
  Misses       1368     1368              
+ Partials      673      671       -2     
Flag Coverage Δ
macos 45.92% <95.45%> (+0.46%) ⬆️
ubuntu 53.71% <95.45%> (+0.29%) ⬆️
ubuntu_curl 53.40% <95.45%> (+0.32%) ⬆️
windows 56.90% <88.46%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmoinvaz nmoinvaz force-pushed the nathan/dev/ipv6_adapter branch 3 times, most recently from 9c1ce01 to 3854db2 Compare December 12, 2023 17:27
@nmoinvaz
Copy link
Owner Author

I expect macOS builds to still fail in CI.

@nmoinvaz nmoinvaz force-pushed the nathan/dev/ipv6_adapter branch from 3854db2 to 59a6e7b Compare December 12, 2023 17:33
@nmoinvaz nmoinvaz merged commit 75e368c into master Dec 12, 2023
16 of 18 checks passed
@nmoinvaz nmoinvaz deleted the nathan/dev/ipv6_adapter branch December 12, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants