win: build with WIN32_LEAN_AND_MEAN macro defined globally #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
==========================================
- Coverage 57.19% 57.10% -0.10%
==========================================
Files 53 53
Lines 4670 4709 +39
Branches 1077 1078 +1
==========================================
+ Hits 2671 2689 +18
- Misses 1307 1322 +15
- Partials 692 698 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sergio-nsk
force-pushed
the
sergio-nsk/mean_and_lean/1
branch
from
034e442 to
8d33844
Compare
sergio-nsk
changed the title
sergio-nsk
added
enhancement
|
Can you try to add a commit that removes |
sergio-nsk
force-pushed
the
sergio-nsk/mean_and_lean/1
branch
from
2f7da37 to
01fd942
Compare
`python3 -u -m pip install gcovr` raised error: externally-managed-environment
sergio-nsk
force-pushed
the
sergio-nsk/mean_and_lean/1
branch
from
01fd942 to
652aa06
Compare
|
It shouldn't be using brew. It should still use python. All I was suggesting was removing |
|
|
|
This is |
|
Hmm |
nmoinvaz
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.