SPTCH-3534: Use already loaded version of JSCoreGTK if available #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 58.73% 59.28% +0.54%
==========================================
Files 53 53
Lines 4709 4721 +12
Branches 1078 1081 +3
==========================================
+ Hits 2766 2799 +33
+ Misses 1336 1320 -16
+ Partials 607 602 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nmoinvaz
force-pushed
the
nathan/dev/SPTCH-3534/1
branch
2 times, most recently
from
b4044ae to
e8d9978
Compare
sergio-nsk
reviewed
Dec 9, 2024
execute_jscore.c
Outdated
Comment on lines
390
to
400
| if (dlinfo(current_process, RTLD_DI_LINKMAP, &map) == 0) { | ||
| while (map && !g_proxy_execute_jscore.module) { | ||
| for (size_t i = 0; i < library_names_size; i++) { | ||
| if (strstr(map->l_name, library_names[i])) { | ||
| g_proxy_execute_jscore.module = dlopen(map->l_name, RTLD_NOLOAD | RTLD_LAZY | RTLD_LOCAL); | ||
| break; | ||
| } | ||
| } | ||
| map = map->l_next; | ||
| } | ||
| } |
There was a problem hiding this comment.
Extremely deep indentations. Can you make a function that exits early if conditions are nor met.
There was a problem hiding this comment.
I think doing a separate function might make it more complex. I have removed one of the indentations though.
nmoinvaz
force-pushed
the
nathan/dev/SPTCH-3534/1
branch
from
e8d9978 to
7b8fabf
Compare
sergio-nsk
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.