Fixed code warnings #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 52.25% 52.24% -0.02%
==========================================
Files 53 53
Lines 4340 4341 +1
Branches 1020 1020
==========================================
Hits 2268 2268
- Misses 1439 1440 +1
Partials 633 633
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sergio-nsk
reviewed
Jan 25, 2023
| @@ -91,7 +91,7 @@ static HRESULT STDMETHODCALLTYPE active_script_site_on_script_error(IActiveScrip | |||
| // Print exception information to log | |||
| HRESULT result = IActiveScriptError_GetExceptionInfo(error, &excep_info); | |||
| if (FAILED(result)) { | |||
| LOG_ERROR("Failed to get active script error (0x%08x)\n", result); | |||
| LOG_ERROR("Failed to get active script error (0x%08lx)\n", result); | |||
There was a problem hiding this comment.
Why don't use PRI* format specifiers?
There was a problem hiding this comment.
They don't have lx only llx
sergio-nsk
requested changes
Jan 25, 2023
nmoinvaz
force-pushed
the
nathan/fix-warnings
branch
from
4d6c15b
to
5e5ab5b
Compare
sergio-nsk
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.