Refactoring/remove mustbeaccepted of requestitemgroup #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@britsta shouldn't this be first done in the runtime? 🤨 |
Sure! Review already requested nmshd/runtime#183 🐸 I just created this draft PR for myself so that I don't forget to change it in the Connector. :D |
|
Oooooh, sorry 😔 don't know Why I was notified |
@jkoenig134 No problem, it may have been my fault 😂 Btw, am I authorized to delete remote branches? I accidentally created one that I would like to remove 😊 |
jkoenig134
previously approved these changes
Jul 8, 2024
sebbi08
previously approved these changes
Jul 9, 2024
jkoenig134
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can only be merged after nmshd/runtime#183 is merged. (Merged now.)
Readiness checklist