Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict either the SSE or the Sync module to be active but not both #224

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Restrict either the SSE or the Sync module to be active but not both #224

merged 2 commits into from
Aug 1, 2024

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Aug 1, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@sebbi08 sebbi08 added the chore Some routine work like updating dependencies label Aug 1, 2024
@sebbi08 sebbi08 requested a review from jkoenig134 August 1, 2024 14:22
@jkoenig134 jkoenig134 changed the title Restrict sse and sync module to one that is active Restrict the SSE and Sync module to only one module that is active Aug 1, 2024
jkoenig134
jkoenig134 reviewed Aug 1, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@jkoenig134 jkoenig134 changed the title Restrict the SSE and Sync module to only one module that is active Restrict either the SSE or the Sync module to be active but not both Aug 1, 2024
jkoenig134
jkoenig134 reviewed Aug 1, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@sebbi08 sebbi08 merged commit 982ff56 into main Aug 1, 2024
9 checks passed
@sebbi08 sebbi08 deleted the feature/restrict_sync_and_see_module branch August 1, 2024 14:44
@jkoenig134 jkoenig134 added bug Something isn't working and removed chore Some routine work like updating dependencies labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebbi08 @jkoenig134