Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to new consumptionConfig to disable setting default RepositoryAttributes #240

Merged
merged 8 commits into from
Aug 22, 2024

Conversation

Milena-Czierlinski
Copy link
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Must await nmshd/runtime#241 .

@Milena-Czierlinski Milena-Czierlinski added the enhancement New feature or request label Aug 21, 2024
@jkoenig134
Copy link
Member

@Milena-Czierlinski I don't think we have to do anything in the connector. It's disabled by default.

@Milena-Czierlinski
Copy link
Contributor Author

The ConsumptionController constructor changed.

@Milena-Czierlinski Milena-Czierlinski added the wip Work in Progress (blocks mergify from auto update the branch) label Aug 22, 2024
@jkoenig134 jkoenig134 removed the wip Work in Progress (blocks mergify from auto update the branch) label Aug 22, 2024
@jkoenig134 jkoenig134 marked this pull request as ready for review August 22, 2024 15:02
@Milena-Czierlinski Milena-Czierlinski merged commit 28015df into release/v5 Aug 22, 2024
10 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the feature/flag-for-default-attributes branch August 22, 2024 15:11
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/ConnectorRuntime.ts 79.32% <100.00%> (+0.05%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants