Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enmeshed-prod as default backbone #242

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Remove enmeshed-prod as default backbone #242

merged 3 commits into from
Aug 22, 2024

Conversation

jkoenig134
Copy link
Member

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Description

  • should be done before -> defaults here are dangerous
  • prod will be shutdown soon

@jkoenig134 jkoenig134 added the breaking-change A breaking change label Aug 22, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

britsta
britsta reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@britsta britsta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of interest: What is "nmshd://prod" in Cors.allowedOrigins of appsettings.override.json?

@jkoenig134
Copy link
Member Author

@britsta this is CORS related and has nothing to do with prod.enmeshed.eu

@jkoenig134 jkoenig134 merged commit 531fffc into release/v5 Aug 22, 2024
9 checks passed
@jkoenig134 jkoenig134 deleted the chore/remove-prod-as-default-backbone branch August 22, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britsta britsta britsta left review comments

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski approved these changes

@slavistan slavistan Awaiting requested review from slavistan

@Magnus-Kuhn Magnus-Kuhn Awaiting requested review from Magnus-Kuhn

Assignees
No one assigned
Labels
breaking-change A breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoenig134 @britsta @Milena-Czierlinski