Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insufficient results during filtering #430

Merged

Conversation

kishorenc
Copy link
Contributor

Very similar in nature to #344

I've discussed this fix with @dyashuni before and this has been tested on a number of datasets.

@dyashuni
Copy link
Contributor

Thank you, @kishorenc

Idea of the fix:
if filter is enabled (!isIdAllowed is false) we don’t care about performance and we should check
top_candidates.size() == ef

if filter is disabled (!isIdAllowed is true) we should have the same behaviour as without filter
top_candidates.size() == ef || !has_deletions

@dyashuni dyashuni self-requested a review January 13, 2023 14:01
@dyashuni
Copy link
Contributor

Thank you, @kishorenc

@dyashuni dyashuni merged commit 978f713 into nmslib:develop Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants