Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.64] probes: retry to get name server list with 2m timeout #1128

Merged
merged 1 commit into from
Oct 31, 2022
Merged

[release-0.64] probes: retry to get name server list with 2m timeout #1128

merged 1 commit into from
Oct 31, 2022

Conversation

rhrazdil
Copy link
Collaborator

@rhrazdil rhrazdil commented Oct 27, 2022 •
edited
Loading

Signed-off-by: Radim Hrazdil rhrazdil@redhat.com

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug
/kind enhancement

What this PR does / why we need it:

Special notes for your reviewer:
Cherry-pick of #1115
Release note:

Fix issue with handler rolling back configuration due to slow update of name servers

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M labels Oct 27, 2022
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 27, 2022
@rhrazdil
Copy link
Collaborator Author

/retest

@rhrazdil
probes: retry to get name server list with 2m timeout (nmstate#1115)
15b8670 
Signed-off-by: Radim Hrazdil <rhrazdil@redhat.com>
@rhrazdil rhrazdil force-pushed the backport_probe_retry_r-0.64 branch 2 times, most recently from b2cfed0 to 15b8670 Compare October 31, 2022 10:17
@qinqon
Copy link
Member

qinqon commented Oct 31, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022
@kubevirt-bot kubevirt-bot merged commit 36ec845 into nmstate:release-0.64 Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek Awaiting requested review from phoracek

@yboaron yboaron Awaiting requested review from yboaron

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhrazdil @qinqon @kubevirt-bot