Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: Remove buildx init/install #1134

Merged
merged 1 commit into from
Jan 13, 2023
Merged

docker: Remove buildx init/install #1134

merged 1 commit into from
Jan 13, 2023

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Jan 3, 2023

What this PR does / why we need it:
The buildx version provided with latest docker is more than enough to has the features needed by the project. This change remove the install and initialization to reduce complexity and versions missalignments.

Release note:

NONE

@qinqon
docker: Remove buildx init/install
5f40938 
The buildx version provided with latest docker is more than enough to
has the features needed by the project. This change remove the install
and initialization to reduce complexity and versions missalignments.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 3, 2023
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023
@qinqon
Copy link
Member Author

qinqon commented Jan 4, 2023

/retest

3 similar comments
@qinqon
Copy link
Member Author

qinqon commented Jan 4, 2023

/retest

@qinqon
Copy link
Member Author

qinqon commented Jan 9, 2023

/retest

@qinqon
Copy link
Member Author

qinqon commented Jan 10, 2023

/retest

@kubevirt-bot
Copy link
Collaborator

kubevirt-bot commented Jan 10, 2023 •
edited
Loading

@qinqon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future 5f40938 link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qinqon
Copy link
Member Author

qinqon commented Jan 12, 2023

/override pull-kubernetes-nmstate-e2e-handler-k8s

not related.

@kubevirt-bot
Copy link
Collaborator

@qinqon: Overrode contexts on behalf of qinqon: pull-kubernetes-nmstate-e2e-handler-k8s

In response to this:

/override pull-kubernetes-nmstate-e2e-handler-k8s

not related.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qinqon
Copy link
Member Author

qinqon commented Jan 13, 2023

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2023
@kubevirt-bot kubevirt-bot merged commit 4bb0cd0 into nmstate:main Jan 13, 2023
qinqon added a commit to qinqon/kubernetes-nmstate that referenced this pull request Jan 24, 2023
@qinqon
Revert "docker: Remove buildx init/install (nmstate#1134)"
0114303 
This reverts commit 4bb0cd0.
@kubevirt-bot kubevirt-bot mentioned this pull request Jan 24, 2023
Merged
qinqon added a commit to qinqon/kubernetes-nmstate that referenced this pull request Jan 24, 2023
@qinqon
Revert "docker: Remove buildx init/install (nmstate#1134)"
f61e45e 
This reverts commit 4bb0cd0.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Jan 25, 2023
@qinqon
Revert "docker: Remove buildx init/install (#1134)" (#1144)
bfc8a6f 
This reverts commit 4bb0cd0.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek approved these changes

@RamLavi RamLavi Awaiting requested review from RamLavi

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinqon @kubevirt-bot @phoracek